Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDC: Implement GMPID #8486

Merged
merged 6 commits into from
Sep 19, 2024
Merged

FDC: Implement GMPID #8486

merged 6 commits into from
Sep 19, 2024

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Sep 7, 2024

No description provided.

@maneesht maneesht requested a review from a team as a code owner September 7, 2024 00:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9e53968

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 7, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (7273df7)Merge (fb952c6)Diff
    browser19.6 kB19.8 kB+118 B (+0.6%)
    esm522.3 kB22.5 kB+120 B (+0.5%)
    main24.2 kB24.3 kB+120 B (+0.5%)
    module19.6 kB19.8 kB+118 B (+0.6%)

  • firebase

    TypeBase (7273df7)Merge (fb952c6)Diff
    firebase-data-connect.js16.4 kB16.5 kB+91 B (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CUOqjNUU90.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 7, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • DataConnect

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • MUTATION_STR

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.0 kB+92 B (+0.3%)

    • MutationManager

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • QUERY_STR

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • SOURCE_CACHE

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • SOURCE_SERVER

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • connectDataConnectEmulator

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • executeMutation

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • executeQuery

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • getDataConnect

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size12.1 kB12.2 kB+92 B (+0.8%)
      size-with-ext-deps37.7 kB37.8 kB+92 B (+0.2%)

    • mutationRef

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.6 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.1 kB30.1 kB+92 B (+0.3%)

    • parseOptions

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.4 kB11.5 kB+92 B (+0.8%)
      size-with-ext-deps29.9 kB30.0 kB+92 B (+0.3%)

    • queryRef

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.6 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • setLogLevel

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • subscribe

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size12.7 kB12.8 kB+92 B (+0.7%)
      size-with-ext-deps38.3 kB38.4 kB+92 B (+0.2%)

    • terminate

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.5 kB11.6 kB+92 B (+0.8%)
      size-with-ext-deps30.0 kB30.1 kB+92 B (+0.3%)

    • toQueryRef

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size12.3 kB12.4 kB+92 B (+0.7%)
      size-with-ext-deps37.9 kB38.0 kB+92 B (+0.2%)

    • validateArgs

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size12.3 kB12.4 kB+92 B (+0.7%)
      size-with-ext-deps37.9 kB38.0 kB+92 B (+0.2%)

    • validateDCOptions

      Size

      TypeBase (7273df7)Merge (fb952c6)Diff
      size11.7 kB11.8 kB+92 B (+0.8%)
      size-with-ext-deps30.2 kB30.3 kB+92 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UvXAANBJVO.html

aashishpatil-g
aashishpatil-g approved these changes Sep 19, 2024
View reviewed changes
config/mocharc.node.js Outdated
@@ -25,7 +25,7 @@
const config = {
require: 'ts-node/register',
timeout: 5000,
retries: 5,
// retries: 5,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks for the catch!

@maneesht maneesht merged commit c23f54e into dataconnect Sep 19, 2024
19 of 21 checks passed
@maneesht maneesht deleted the mtewani/implement-gmpid branch September 19, 2024 22:52
@firebase firebase locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maneesht @google-oss-bot @aashishpatil-g